[Bugfix:TAGrading] Prevent Grade Stealing#12434
Conversation
| itempool_items: Record<number, string>; | ||
| }; | ||
|
|
||
| /** |
There was a problem hiding this comment.
move all the variables under the type definitions
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12434 +/- ##
============================================
+ Coverage 21.67% 21.73% +0.06%
Complexity 9623 9623
============================================
Files 268 268
Lines 36171 36167 -4
Branches 486 486
============================================
+ Hits 7840 7862 +22
+ Misses 27849 27823 -26
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JManion32
left a comment
There was a problem hiding this comment.
Yay! Great work with this. I tested on main and replicated the issue when clicking next/prev and home, and could no longer replicate on this branch.
Just make sure to properly tag the issue here so it automatically closes. I understand this may not be the most optimal solution, so maybe we should make a new, non-URGENT/PRIORITY issue that documents it (or add it to an existing TA grading refactor issue).
Rkoester47
left a comment
There was a problem hiding this comment.
I was able to replicate this issue on main, but not on this branch. I tried opening and closing the grading component multiple times as a different grader, scrolling left and right through different student submissions with a grading component open, and made sure that intentional regrading is still functional. The changes made by this PR seem to have resolved the issue as I cannot steal credit from other graders in my testing.
Why is this Change Important & Necessary?
fixes #12223 Fixes grade stealing on going to home page
What is the New Behavior?
No grade stealing on going to home page. Added a new window element for a temporary fix while we convert this to vue
What steps should a reviewer take to reproduce or test the bug or new feature?
I tested going to previous student, going to next student, and going to home page while not on instructor grading a component. With no changes, this keeps instructor as the sole grader. With changes, the text changes to the user on refresh.
Automated Testing & Documentation
N/A. Convert to vue first before E2e Tests
Other information
Thank you Justin for tracking the issue so clearly