[Bugfix:System] Fix opencv migration dep#12419
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12419 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9623 9623
=========================================
Files 268 268
Lines 36171 36171
Branches 486 486
=========================================
Hits 7840 7840
Misses 27849 27849
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
CI is failing https://github.com/Submitty/Submitty/actions/runs/21803157121/job/62902011782
An old migration has a non stdlib import. That functionality can easily be replaced with stdlib python functionality.
What is the New Behavior?
CI passes.
Other information
It seems that non stdlib library is not present on the latest runners. We could consider installing it but it doesn't make sense given we only need it for a single migration. Editing old migrations is usually not best practice to do but no point keeping a dependency around for just that.