[Bugfix:System] Fix course creation page#12418
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12418 +/- ##
============================================
+ Coverage 21.67% 21.73% +0.06%
Complexity 9623 9623
============================================
Files 268 268
Lines 36171 36167 -4
Branches 486 486
============================================
+ Hits 7840 7862 +22
+ Misses 27849 27823 -26
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rkoester47
left a comment
There was a problem hiding this comment.
I checked and was able to reproduce the issue on main. I was able to see the error created in var/local/submitty/logs/course_creation. On this branch, the issue is resolved and I was able to create a new course immediately. The code implementation makes sense and is a good solution, also updating references to 'Semester' to be 'Term' instead to help consistency within Submitty.
John-Roy123
left a comment
There was a problem hiding this comment.
I was able to replicate the issue on main - attempting to generate a course resulted in a popup saying "request was sent" with the course never appearing. After running your changes I was able to create a new course and have it appear after a refresh.
I also appreciate the code changes to have the code be more explicit/readable in what information the variables contain.
Why is this Change Important & Necessary?
When you create a course in the "New Course" page, the course never gets created. An error is created in the
/var/local/submitty/logs/course_creation/directory.What is the New Behavior?
Courses are created as usual.
What steps should a reviewer take to reproduce or test the bug or new feature?
Try to create a new course in the "New Course" page and verify it is properly created and you can see it.
Automated Testing & Documentation
Unit tests added