[Dependency] Stylelint to v17, Standard Config to v40#12415
Merged
williamjallen merged 2 commits intomainfrom Feb 7, 2026
Merged
[Dependency] Stylelint to v17, Standard Config to v40#12415williamjallen merged 2 commits intomainfrom
williamjallen merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12415 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9623 9623
=========================================
Files 268 268
Lines 36171 36171
Branches 486 486
=========================================
Hits 7840 7840
Misses 27849 27849
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
It seems to be just those. I ran Stylelint locally and also got errors for override.css, but this seems to be ignored on CI?
Contributor
Author
|
@williamjallen This is ready for review. I looked through the Stylelint migration guide and was surprised to see that we didn't need to take much action this time around. Let me know if there's anything I missed! |
williamjallen
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Both Stylelint and Stylelint Standard Config had major version bumps that depend on one another (see #12369 and #12389). These are peer dependencies, and thus we can't do one without the other.
What is the New Behavior?
Ran
npm install --save-dev stylelint@17.1.0 stylelint-config-standard@40.0.0to update both dependencies at once. There should be no ERESOLVE errors on this PR since npm will now be able to run without error.What steps should a reviewer take to reproduce or test the bug or new feature?
Are all code changes acceptable, conforming to Submitty best design practices as well as the new rules set by Stylelint?
Automated Testing & Documentation
GitHub formatter has been removed from Stylelint. This is not a problem for our project as we only run a check on CI.
Other information
We need to combine Stylelint and the Stylelint Standard Config so we can avoid future peer dependency conflicts. I think this will continue to happen with each major version bump if we do not.