[Refactor:Developer] Strict Eslint warnings on CI#12403
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12403 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9620 9620
=========================================
Files 268 268
Lines 36164 36164
Branches 486 486
=========================================
Hits 7837 7837
Misses 27845 27845
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JManion32
reviewed
Feb 2, 2026
Contributor
JManion32
left a comment
There was a problem hiding this comment.
Looks great! I think this is very necessary.
I believe the issue with the no-template-shadow warning is that the file has a course prop, and then tries to introduce a variable with the same name for the loop at line 137.
Based on my testing I think you can just delete that prop entirely. It's not passed in from the PHP view, and is only a necessary prop in the child component, NotificationDisplay.vue.
cjreed121
requested changes
Feb 4, 2026
cjreed121
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Several warnings that could have been fixed by developers were uncaught due to it being warnings. For example, our indenting rule was violated by some files and was only a warning.
What is the New Behavior?
added Max warning. We need some of the warnings such as v-html as I have no idea how to ignore it. Ignoring it line by line doesnt work and ignoring the entire file doe not work either.
We can add these rules to eslint errors, but we should also limit warnings so that we can caught future warnings that should be errors as well
What steps should a reviewer take to reproduce or test the bug or new feature?
Review the code, run the command in ci.yml to see that warnings went down.
Automated Testing & Documentation
Changing CI tests
Other information