[Bugfix:Developer] Filter unit test in submitty_test #12402
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12402 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9620 9620
=========================================
Files 268 268
Lines 36164 36164
Branches 486 486
=========================================
Hits 7837 7837
Misses 27845 27845
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
cjreed121
reviewed
Feb 4, 2026
cjreed121
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
According to our documentation, https://submitty.org/developer/testing/php_unit_tests, there is a filter option that could be passed to php-unit. For people debugging single unit tests, this command is very helpful. However, in our submitty_test file, we do not allow passing in command line arguments to unit tests. Like other commands in submitty_test, we should allow it to take in arguments to help the developer
What is the New Behavior?
Allow
submitty_test php-unitto take in commands, mimicking other functionsWhat steps should a reviewer take to reproduce or test the bug or new feature?
submitty_test php-unit --filter testRunQueryRunstestRunQueryfromSqlToolboxControllerTester.phpAutomated Testing & Documentation
N/A
Other information