Skip to content

[Testing:System] Remove old field from notebook example#12362

Merged
bmcutler merged 1 commit intomainfrom
remove_hide_submitted_files
Feb 5, 2026
Merged

[Testing:System] Remove old field from notebook example#12362
bmcutler merged 1 commit intomainfrom
remove_hide_submitted_files

Conversation

@cjreed121
Copy link
Member

@cjreed121 cjreed121 commented Feb 1, 2026

Why is this Change Important & Necessary?

Lingering change from #7804

See warning/error in https://github.com/Submitty/Submitty/actions/runs/21500146068/job/61944467809#step:5:12258

What is the New Behavior?

hide_submitted_files, an invalid config value, is now removed from the notebook_expected_string config example.

@github-project-automation github-project-automation bot moved this to Seeking Reviewer in Submitty Development Feb 1, 2026
@codecov
Copy link

codecov bot commented Feb 1, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.67%. Comparing base (a362c30) to head (b0025da).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12362   +/-   ##
=========================================
  Coverage     21.67%   21.67%           
  Complexity     9620     9620           
=========================================
  Files           268      268           
  Lines         36164    36164           
  Branches        486      486           
=========================================
  Hits           7837     7837           
  Misses        27845    27845           
  Partials        482      482
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.04% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.69% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Eli-J-Schwartz Eli-J-Schwartz self-assigned this Feb 1, 2026
@Eli-J-Schwartz
Copy link
Contributor

Eli-J-Schwartz commented Feb 1, 2026

I took a look at the original warning (line 12258 in the vagrant up step of the linked job), and noticed that the warning present refers to the invalid JSON parameter hide_submitted_files. Looking at the modified config example, this is exactly what was removed, presumably solving the error. Since the PR did not include testing instructions, I am unsure how this can be tested without rerunning the vagrant-up job, which would take a significant amount of time (2+ hours). Despite this, the PR appears to be simple enough to solve the problem without causing any additional errors.

Rkoester47
Rkoester47 approved these changes Feb 4, 2026
View reviewed changes
Copy link
Contributor

@Rkoester47 Rkoester47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the invalid config value was removed in the way from the linked PR. After the removal on this branch, I can't find 'hide_submitted_files' anywhere else.

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Feb 4, 2026
@williamschen23
Copy link
Contributor

williamschen23 commented Feb 4, 2026

I took a look at the original warning (line 12258 in the vagrant up step of the linked job), and noticed that the warning present refers to the invalid JSON parameter hide_submitted_files. Looking at the modified config example, this is exactly what was removed, presumably solving the error. Since the PR did not include testing instructions, I am unsure how this can be tested without rerunning the vagrant-up job, which would take a significant amount of time (2+ hours). Despite this, the PR appears to be simple enough to solve the problem without causing any additional errors.

You can rebuild the gradeable and see the errors. Log in as instructor, click arrow next teh gradeable to edit, and move to autograding tab, and click rebuild at the bottom.

@williamschen23
Copy link
Contributor

williamschen23 commented Feb 4, 2026

related to #7246, could close? if necessary but I am unsure

@cjreed121
Copy link
Member Author

cjreed121 commented Feb 5, 2026

related to #7246, could close? if necessary but I am unsure

Yeah definitely related. I'd argue #7804 may have resolved that issue. It would be good for @bmcutler to verify if everything there has been addressed with that config being moved to the UI.

I don't think this blocks this PR in any way but still good to potentially address that issue.

@bmcutler bmcutler merged commit d7d1bbf into main Feb 5, 2026
49 of 50 checks passed
@bmcutler bmcutler deleted the remove_hide_submitted_files branch February 5, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rkoester47 Rkoester47 Rkoester47 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Submitty Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cjreed121 @Eli-J-Schwartz @williamschen23 @Rkoester47 @bmcutler