Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12359 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9623 9623
=========================================
Files 268 268
Lines 36171 36171
Branches 486 486
=========================================
Hits 7840 7840
Misses 27849 27849
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| <samp>git clone {{ repository_path }} SPECIFY_TARGET_DIRECTORY </samp><br><br> | ||
| <span><em>You will log in using </em> '<code>{{user_id}}</code>'<em> as your username and VCS / GIT Authentication Token as the password. Click the button below to generate a VCS / GIT Authentication Token for Submitty if this is your first time using GIT with Submitty. </em></span> | ||
| {# Below will get uncommented once SAML is active #} | ||
| {# <p>You will need to use an Authentication Token.</p> #} |
There was a problem hiding this comment.
Hmm, this forgotten note about SAML and being required to use an Authentication token should be addressed. At RPI, we are using SAML and students cannot use their password -- they must use the authentication tokens. This commented out message should print out at RPI.
But it should not print for some other school does not use SAML and does allow students to use their password for GIT (or using the authentication token is also allowed).
There was a problem hiding this comment.
@roye2 we should try to test with and without saml
(these step are to configure a server for saml -- might not go smoothly on vagrant)
https://submitty.org/sysadmin/configuration/saml_authentication
There was a problem hiding this comment.
Looking at the lines below, it does look like it was addressed but we just forgot to remove the TODO comment. Whoops... Feel free to remove that comment in this PR @roye2.
See https://github.com/Submitty/Submitty/blob/main/.setup/testing/setup_saml.sh if you want to setup SAML on the vagrant box. I don't know if anyone has tested that script locally in a while but should still work since we test SAML in CI.
There was a problem hiding this comment.
Thanks, I'll take a look and make sure everything's working when I remove the comment. I can also test the SAML script locally just to make sure.
…ions-with-access-tokens
… updated formatting on Authentication token page :)
…ccess-tokens' of https://github.com/Submitty/Submitty into 12357-improve-on-page-submit-by-git-instructions-with-access-tokens
|
Updated Changes Summary + Screenshots: 
Added new messaging from previous commits to Team VCS Gradeables. |
…ions-with-access-tokens
Co-authored-by: Chris Reed <55092742+cjreed121@users.noreply.github.com>
cjreed121
left a comment
There was a problem hiding this comment.
Changes look good after my last 2 comments
Co-authored-by: Chris Reed <55092742+cjreed121@users.noreply.github.com>
Rkoester47
left a comment
There was a problem hiding this comment.
The changes made on this branch work as described by the PR. I believe adding these messages will be helpful for students who are new to using this part of Submitty. I agree with the wording changes made in a recent commit as well, providing more clear messaging for users. Your implementation also looks solid and intuitive. Overall, good work!
the TeamView.php file did not pass the user id into the Team.twig file, causing a bug.
Partially addresses #12357
New Behavior:
A message now appears explaining the submission process on Submit-by-Git gradeables.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
Note from Emma: I left this part in because I wasn't sure how to answer it. I can update it later.
Other information
Thus is not a breaking change.
There are no security concerns associated.
The second part of Issue #12357 will be addressed in a separate PR.