Skip to content

[Bugfix:Developer] Fix Broken CI Tests#12358

Merged
bmcutler merged 2 commits intomainfrom
fix-tests
Jan 30, 2026
Merged

[Bugfix:Developer] Fix Broken CI Tests#12358
bmcutler merged 2 commits intomainfrom
fix-tests

Conversation

@IDzyre
Copy link
Member

@IDzyre IDzyre commented Jan 29, 2026

Why is this Change Important & Necessary?

We want to keep the tests passing as much as we can, recently a couple of PRs caused tests to fail on main (and every PR).

What is the New Behavior?

The JavaScript tests, and the Cypress tests now pass.

What steps should a reviewer take to reproduce or test the bug or new feature?

See that the tests pass in CI, and if you want to, run submitty_test js in your VM, and run the Cypress tests

@github-project-automation github-project-automation bot moved this to Seeking Reviewer in Submitty Development Jan 29, 2026
@automateprojectmangement automateprojectmangement bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jan 29, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.67%. Comparing base (7853e42) to head (de27265).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12358   +/-   ##
=========================================
  Coverage     21.67%   21.67%           
  Complexity     9620     9620           
=========================================
  Files           268      268           
  Lines         36164    36164           
  Branches        486      486           
=========================================
  Hits           7837     7837           
  Misses        27845    27845           
  Partials        482      482
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.04% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.69% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IDzyre IDzyre changed the title [Bugfix:Testing] Fix Broken JS and Cypress Tests [Bugfix:Testing] Fix Broken CI Tests Jan 29, 2026
@JManion32
Copy link
Contributor

JManion32 commented Jan 29, 2026

#12287 caused this. I can help look into it later tonight/tomorrow if you'd like.

@IDzyre
Copy link
Member Author

IDzyre commented Jan 29, 2026

The main thing I need is to see if the TAGrading test is failing because it's not being updated (and the values are reflecting that) or something else.

@JManion32
Resolved Failing TA Grading Tests
de27265 
In the original PR, I was messing around with the CSS classes. I realized that a lot of the JS logic uses .cell-grade, so I reverted most of my changes, but forgot this one.
@JManion32
Copy link
Contributor

JManion32 commented Jan 30, 2026 •
edited
Loading

@IDzyre The TA Grading tests are now passing locally for me with this change. The .cell-grade selector is used in the simple-grading.js logic, which is why is was no longer updating. The .cell-entry class doesn't exist anymore and should've instead been .cell-grade like it was before I started messing with the CSS in #12287.

@JManion32 JManion32 changed the title [Bugfix:Testing] Fix Broken CI Tests [Bugfix:Developer] Fix Broken CI Tests Jan 30, 2026
@JManion32 JManion32 marked this pull request as ready for review January 30, 2026 13:59
@automateprojectmangement automateprojectmangement bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Jan 30, 2026
JManion32
JManion32 approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@JManion32 JManion32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is passing!

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Jan 30, 2026
@bmcutler bmcutler merged commit 0bfd288 into main Jan 30, 2026
26 of 27 checks passed
@bmcutler bmcutler deleted the fix-tests branch January 30, 2026 18:22
@github-project-automation github-project-automation bot moved this from Awaiting Maintainer Review to Done in Submitty Development Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JManion32 JManion32 JManion32 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Submitty Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IDzyre @JManion32 @bmcutler