[Bugfix:Developer] Fix ansible install with SSL#12355
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12355 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9620 9620
=========================================
Files 268 268
Lines 36164 36164
Branches 486 486
=========================================
Hits 7837 7837
Misses 27845 27845
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
cjreed121
requested changes
Jan 31, 2026
Member
|
Can you update the docs too for these latest changes? https://submitty.org/sysadmin/installation/ansible I'm at least assuming the below section has changes?
|
cjreed121
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why is this Change Important & Necessary?
The install process has changed slightly since the ansible scripts were added, and the initial scripts weren't created with SSL in mind. Also, the certificate and key files were hardcoded, so if you had different locations, you had to manually go change it.
What is the New Behavior?
The main change is adding a variable for the SSL certificate and key files, allowing for sysadmins to create the full Submitty instance without having to manually change the SSL certificate path.
The defaults.yml file is re-arranged to match more with the order of the questions asked by CONFIGURE_SUBMITTY.yml
By default, uses PAM authentication, so a few parameters weren't being used (and messing with the order of CONFIGURE_SUBMITTY), so they have been removed.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
This is not currently tested with CI, because testing certificates would probably be hard. The default intall (local, no ssl) is tested with CI.
Docs have been updated in Submitty/submitty.github.io#724