Skip to content

[Bugfix:Developer] Fix ansible install with SSL#12355

Merged
bmcutler merged 10 commits intomainfrom
ansible-fix
Feb 5, 2026
Merged

[Bugfix:Developer] Fix ansible install with SSL#12355
bmcutler merged 10 commits intomainfrom
ansible-fix

Conversation

@IDzyre
Copy link
Member

@IDzyre IDzyre commented Jan 27, 2026

Why is this Change Important & Necessary?

The install process has changed slightly since the ansible scripts were added, and the initial scripts weren't created with SSL in mind. Also, the certificate and key files were hardcoded, so if you had different locations, you had to manually go change it.

What is the New Behavior?

The main change is adding a variable for the SSL certificate and key files, allowing for sysadmins to create the full Submitty instance without having to manually change the SSL certificate path.

The defaults.yml file is re-arranged to match more with the order of the questions asked by CONFIGURE_SUBMITTY.yml

By default, uses PAM authentication, so a few parameters weren't being used (and messing with the order of CONFIGURE_SUBMITTY), so they have been removed.

What steps should a reviewer take to reproduce or test the bug or new feature?

Automated Testing & Documentation

This is not currently tested with CI, because testing certificates would probably be hard. The default intall (local, no ssl) is tested with CI.
Docs have been updated in Submitty/submitty.github.io#724

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.67%. Comparing base (0bfd288) to head (724896c).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12355   +/-   ##
=========================================
  Coverage     21.67%   21.67%           
  Complexity     9620     9620           
=========================================
  Files           268      268           
  Lines         36164    36164           
  Branches        486      486           
=========================================
  Hits           7837     7837           
  Misses        27845    27845           
  Partials        482      482           
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.04% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.69% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jan 31, 2026
@cjreed121
Copy link
Member

cjreed121 commented Jan 31, 2026

Can you update the docs too for these latest changes?

https://submitty.org/sysadmin/installation/ansible

I'm at least assuming the below section has changes?

image

@github-project-automation github-project-automation bot moved this from Work in Progress to Awaiting Maintainer Review in Submitty Development Feb 3, 2026
@cjreed121 cjreed121 moved this from Awaiting Maintainer Review to Ready to Merge in Submitty Development Feb 3, 2026
@bmcutler bmcutler merged commit d868340 into main Feb 5, 2026
26 checks passed
@bmcutler bmcutler deleted the ansible-fix branch February 5, 2026 21:57
@github-project-automation github-project-automation bot moved this from Ready to Merge to Done in Submitty Development Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants