Skip to content

[Bugfix:System] Added Spacing for Mobile Sidebar Btns#12350

Merged
williamjallen merged 2 commits intomainfrom
fix-sidebar-spacing
Jan 27, 2026
Merged

[Bugfix:System] Added Spacing for Mobile Sidebar Btns#12350
williamjallen merged 2 commits intomainfrom
fix-sidebar-spacing

Conversation

@JManion32
Copy link
Contributor

Why is this Change Important & Necessary?

The mobile sidebar has no spacing between badges and titles
image

What is the New Behavior?

Added 12px of spacing between badges and titles
image

What steps should a reviewer take to reproduce or test the bug or new feature?

Observer no spacing on main sidebar, and spacing on topic branch sidebar
If there is any other improvements that could be made to the mobile sidebar in this PR, please let me know!

Automated Testing & Documentation

N / A

Other information

This is not a breaking change.

@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.67%. Comparing base (ea63f36) to head (cef761c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12350   +/-   ##
=========================================
  Coverage     21.67%   21.67%           
  Complexity     9618     9618           
=========================================
  Files           268      268           
  Lines         36158    36158           
  Branches        486      486           
=========================================
  Hits           7837     7837           
  Misses        27839    27839           
  Partials        482      482           
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.04% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.69% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JManion32 JManion32 changed the title [Bugfix:StudentUI] Added Spacing for Mobile Sidebar Btns [Bugfix:System] Added Spacing for Mobile Sidebar Btns Jan 25, 2026
Thought I needed to create a new class, but won't need it
@Eli-J-Schwartz
Copy link
Contributor

As the PR says, there is now spacing between the menu items and icons on mobile devices. Using Firefox Devtools, I tested on multiple different screen resolutions and rotations, as well as in both light and dark mode. The menu fix displayed properly in all of them.

Unrelated to this fix, I noticed that several subpages on Submitty fail to display a mobile interface at all, such as the discussion forum. I have created a new issue for this: #12352

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Jan 27, 2026
@williamjallen williamjallen merged commit f2fc7e1 into main Jan 27, 2026
65 of 71 checks passed
@williamjallen williamjallen deleted the fix-sidebar-spacing branch January 27, 2026 01:52
@github-project-automation github-project-automation bot moved this from Awaiting Maintainer Review to Done in Submitty Development Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants