[Bugfix:System] Fix VCS Download and Submission#12334
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12334 +/- ##
=========================================
Coverage 21.69% 21.69%
Complexity 9617 9617
=========================================
Files 268 268
Lines 36115 36115
Branches 478 478
=========================================
Hits 7836 7836
Misses 27805 27805
Partials 474 474
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
williamjallen
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Currently, when you download the gradeable json, if you are using a subdirectory, it does not save it in the way that the upload is expecting.
Download saves it as
subdirectory => <subdirectory>Upload wants it as
'vcs_subdirectory' => <subdirectory>Also, when using self hosted VCS gradeables, the 'grade my repository' section does not show up, so students could not submit.
What is the New Behavior?
The download now saves it in the way that the upload is looking for.
Also allows self hosted vcs type to click 'grade my repository'.
What steps should a reviewer take to reproduce or test the bug or new feature?
On main, download the gradeable JSON from the vcs subdirectory homework, change the id, and upload it. You will notice the subdirectory is not copied.
Switch to this branch, and do it again, and it will be there.
For self hosted, on main create a gradeable with the 'self hosted' vcs type, and go to submit the gradeable. Notice there is no 'Grade My Repository' button.
Switch to this branch and notice the button appears.
Automated Testing & Documentation
Test has been updated to reflect the new expected values.