[Bugfix:Notifications] Post Preview for Forum Emails#12277
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12277 +/- ##
============================================
- Coverage 21.69% 21.67% -0.03%
- Complexity 9617 9620 +3
============================================
Files 268 268
Lines 36115 36164 +49
Branches 478 486 +8
============================================
+ Hits 7836 7837 +1
- Misses 27805 27845 +40
- Partials 474 482 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
RyanStyron
approved these changes
Jan 16, 2026
Contributor
RyanStyron
left a comment
There was a problem hiding this comment.
Largely agree with the intent behind the pull request. Functions well. Looks good to me.
Changed the length of the preview to 100 characters, and changed the wording of the output message.
roye2
approved these changes
Jan 27, 2026
Contributor
roye2
left a comment
There was a problem hiding this comment.
Code looks good and makes sense to me, meaning the commenting is pretty clear. I tested the change and it appears to work as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Fixes #12276
Previously, the email notification sent out included just a portion of the original post and the entirety of the reply post. This was changed at some point to include the entire original post. This might not be a problem for shorter original posts, but for longer ones it would result in a long email.
What is the New Behavior?
Now, if the original post content long it gets truncated by a helper function. If it is shorter than this preset value, the entire post gets included in the email.
What steps should a reviewer take to reproduce or test the bug or new feature?
Additional information about email use here: https://submitty.org/developer/development_instructions/vagrant_email_configuration
Automated Testing & Documentation
Other information
This is not a breaking change.