[Bugfix:InstructorUI] Allow floats for grade override#12270
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12270 +/- ##
=========================================
Coverage 21.69% 21.69%
- Complexity 9617 9618 +1
=========================================
Files 268 268
Lines 36113 36113
Branches 478 478
=========================================
Hits 7835 7835
Misses 27804 27804
Partials 474 474
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rkoester47
approved these changes
Dec 4, 2025
Contributor
Rkoester47
left a comment
There was a problem hiding this comment.
I was successfully able to use a float when creating a grade override for a student. There were no issues with entering the value, and it showed up in the rainbow grades summary for the student afterwards as intended.
JManion32
approved these changes
Dec 9, 2025
Contributor
JManion32
left a comment
There was a problem hiding this comment.
Replicated the issue on main and verified that this fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Grade Override does not allow for floats for grades. If we have a gradeable that we need to give someone partial credit, we are unable to do it.
What is the New Behavior?
Allows floats. Changes the type signature.
What steps should a reviewer take to reproduce or test the bug or new feature?
Verify that floats can be stored
Automated Testing & Documentation
Other information