[Bugfix:InstructorUI] Fix Withdrawn Students Filter in Grading#12268
[Bugfix:InstructorUI] Fix Withdrawn Students Filter in Grading#12268
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12268 +/- ##
============================================
- Coverage 21.69% 21.67% -0.03%
Complexity 9617 9617
============================================
Files 268 268
Lines 36115 36153 +38
Branches 478 486 +8
============================================
Hits 7836 7836
- Misses 27805 27835 +30
- Partials 474 482 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rkoester47
left a comment
There was a problem hiding this comment.
I tested these changes and can confirm that the issue has been resolved. I made sure to check that it works properly with an odd and even number of graders and in both electronic and simple gradeables. I also made sure that the above worked with both a full permission grader as well as a limited permission one. In all cases, the students' numbering was updated dynamically as the withdrawn students were hidden and un-hidden.
williamschen23
left a comment
There was a problem hiding this comment.
Overall, i see a lot of repeating code. I know that simple and electronic both uses different files, but is it not possible to combine them? Also, this looks like a very messy way to do it. Is there no better way?
|
@williamschen23 - I pushed changes to reduce duplicate logic and make other small abstractions. |
…kout-gradeable-rendering
|
Theres a mismatch between colors: |
…kout-gradeable-rendering
williamschen23
left a comment
There was a problem hiding this comment.
Please change the functionality to "omit" withdrawn students automatically
Screen.Recording.2026-01-16.at.12.59.45.PM.movclicking the checkpoint cell doesn't update, but updates after a refresh. Other functionality works good |
…le grading checkpoint display logic for proper visualization.
@williamschen23 |
williamschen23
left a comment
There was a problem hiding this comment.
The toggle for withdrawn students work well.
But now the checkmarks for the other 4 checkboxes are broken. If you go to an electronic gradeables grading, you can click a checkbox and it wont appear as checked but the page appears as checked
williamschen23
left a comment
There was a problem hiding this comment.
I think that you should revert your last PR and apply the changes in the comments here
…es related to checkbox state saving logic.
williamschen23
left a comment
There was a problem hiding this comment.
Thanks for the changes!
Why is this Change Important & Necessary?
Fixes #12210.
As detailed by the issue, the Grading interface (for both "simple" (typically for labs) and "electronic" (typically for assignments, exams, etc.) grading) has a display bug where hiding withdrawn students does not update the index and the shading of the given row to match the color alternation scheme.
What is the New Behavior?
Tested with two students withdrawn from
samplecourse, specifically studentsaphackerandfarred.With the changes applied to "simple" grading:
With the changes applied to "electronic" grading:
What steps should a reviewer take to reproduce or test the bug or new feature?
Follow the instructions in the linked issue. I would further recommend testing both "simple" and "electronic" grading, separately with an even and odd amount of students withdrawn from the course. Also ensure that this works for graders with full and limited access.