Skip to content

[Bugfix:RainbowGrades] Fix Rainbow Grades Configuration Title#12147

Merged
bmcutler merged 1 commit intomainfrom
Rainbow-Grades-configuration-title-change
Oct 24, 2025
Merged

[Bugfix:RainbowGrades] Fix Rainbow Grades Configuration Title#12147
bmcutler merged 1 commit intomainfrom
Rainbow-Grades-configuration-title-change

Conversation

@Rkoester47
Copy link
Contributor

@Rkoester47 Rkoester47 commented Oct 20, 2025

Why is this Change Important & Necessary?

Currently, the Grades Configuration button on the left of the page leads to a page with "Submitty > Sample > Rainbow Grades Customization" at the top, even though the page title just below says "Rainbow Grades Configuration". This is awkward looking and somewhat confusing as to the actual page title.

Before: (Firefox)
RainbowGradesCustomization

What is the New Behavior?

Now the top reads "Submitty > Sample > Rainbow Grades Configuration" which matches the title of the page just below. This helps with both clarity in navigating the site, as well as improving the consistency of site page naming.

After: (Firefox)
RainbowGradesConfiguration

What steps should a reviewer take to reproduce or test the bug or new feature?

Click on Grades Configuration and confirm that the top banner page title matches the main title of the page below it, and that both say "Rainbow Grades Configuration".

Automated Testing & Documentation

Other information

This is not a breaking change.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 21.68%. Comparing base (b2d290e) to head (189242f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12147   +/-   ##
=========================================
  Coverage     21.68%   21.68%           
  Complexity     9598     9598           
=========================================
  Files           268      268           
  Lines         36620    36620           
  Branches        475      475           
=========================================
  Hits           7941     7941           
  Misses        28208    28208           
  Partials        471      471           
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.07% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.69% <0.00%> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rkoester47 Rkoester47 changed the title [Bugfix:RainbowGrades] Fix Rainbow Grades Configuration Page Title [Bugfix:RainbowGrades] Fix Rainbow Grades Configuration Title Oct 20, 2025
@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Oct 21, 2025
@skara9 skara9 moved this from Awaiting Maintainer Review to Ready to Merge in Submitty Development Oct 21, 2025
@bmcutler bmcutler merged commit c85f140 into main Oct 24, 2025
28 of 30 checks passed
@bmcutler bmcutler deleted the Rainbow-Grades-configuration-title-change branch October 24, 2025 00:21
@github-project-automation github-project-automation bot moved this from Ready to Merge to Done in Submitty Development Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants