[Bugfix:Forum] Fix server crash editing markdown#12142
Merged
williamjallen merged 1 commit intomainfrom Oct 18, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12142 +/- ##
=========================================
Coverage 21.68% 21.68%
Complexity 9598 9598
=========================================
Files 268 268
Lines 36620 36620
Branches 475 475
=========================================
Hits 7941 7941
Misses 28208 28208
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
RyanStyron
approved these changes
Oct 17, 2025
Contributor
RyanStyron
left a comment
There was a problem hiding this comment.
Tested and was able to replicate the issue as described. The solution is confined and resolves the error. Great job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Fixes #12130
There has been a rare but recurring server crash on the forum when editing posts due to an expected input not existing. After investigation, this is related to markdown, specifically clicking "Update Post" while the markdown editor is in "preview" mode.
Repro Steps:
What is the New Behavior?
This occurs because the relevant textarea is conditionally rendered using
v-if, which removes it from the DOM when unrendered. By switching this tov-show, this input remains in the DOM and its contents can be accessed and sent with the edit submission.What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
Other information