Skip to content

[Feature:TAGrading] PDF Zoom for Submissions#12140

Merged
bmcutler merged 5 commits intomainfrom
pdf-zoom
Oct 17, 2025
Merged

[Feature:TAGrading] PDF Zoom for Submissions#12140
bmcutler merged 5 commits intomainfrom
pdf-zoom

Conversation

@skara9
Copy link
Contributor

@skara9 skara9 commented Oct 14, 2025

Why is this Change Important & Necessary?

There is no functionality for graders to zoom in on submitted PDFs.
Resolves #12084

What is the New Behavior?

Submitted PDFs can be zoomed by trackpad or holding down Ctrl/Cmd and scrolling the mouse.
Buttons for zooming in and out in 10% intervals are also present.

submitty.pdf.zoom.mov

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.68%. Comparing base (9733059) to head (a1fa15e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12140   +/-   ##
=========================================
  Coverage     21.68%   21.68%           
  Complexity     9598     9598           
=========================================
  Files           268      268           
  Lines         36620    36620           
  Branches        475      475           
=========================================
  Hits           7941     7941           
  Misses        28208    28208           
  Partials        471      471           
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.07% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.69% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Rkoester47 Rkoester47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to zoom in the PDF submission for a homework successfully. I could do both a trackpad zoom in/out and also hold control + scroll to zoom. I tested this on a Windows device in Firefox. Overall, it seems like a good change that is working properly.

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Oct 14, 2025
Copy link
Contributor

@RyanStyron RyanStyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a Chrome browser and can confirm that the functionality of the zoom feature as part of the grading panel is as intended.

@bmcutler bmcutler merged commit 70890ea into main Oct 17, 2025
23 of 25 checks passed
@bmcutler bmcutler deleted the pdf-zoom branch October 17, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

PDF Zoom for TA grading of scanned exam

4 participants