[Feature:TAGrading] Make active graders an outline#12128
Conversation
…better visual clarity
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12128 +/- ##
=========================================
Coverage 21.68% 21.68%
Complexity 9598 9598
=========================================
Files 268 268
Lines 36620 36620
Branches 475 475
=========================================
Hits 7941 7941
Misses 28208 28208
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rkoester47
left a comment
There was a problem hiding this comment.
I tested the grading-in-progress symbol on both main and this branch, and I think the red outline is a strong idea. It makes it more clear that the problem has begun being graded, but is not finished. This change removes ambiguity from the grading process and is intuitive to me.
If I had to nitpick one thing, I think the red circle could be a bit bolder. I tested the view in both light and dark mode, and the red circle is somewhat difficult to notice in light mode especially. Even with brightness turned up, the red circle almost disappears and I could see some people with brightness turned down on light mode maybe missing it.
Otherwise, I really like the change and I think it improves the usability of the page. 'i think a slightly bolder outline on the red circle would help readability.
Rkoester47
left a comment
There was a problem hiding this comment.
The thicker red circle is more readable and much more clear.
|
I'm merging this now, but since this is changing the UI (even if it is not a significant visual change) it should have at a minimum 1 screenshot. The description is very short and not 100% clear for a newer dev or for a dev or admin who is not familiar with this feature of Submitty. Please edit the PR message to add a screenshot to the message for development documentation. Thanks. |
Why is this Change Important & Necessary?
Active grader indicators were full red circles, which made it impossible to see the status of the component outside of whether or not it is being graded.
What is the New Behavior?
The new behavior is that whether or not a component is being graded is represented by a red outline on the component circle.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
Other information