Skip to content

[Bugfix:TAGrading] Fix component auto-open#12127

Merged
bmcutler merged 2 commits intomainfrom
fix-auto-open
Oct 3, 2025
Merged

[Bugfix:TAGrading] Fix component auto-open#12127
bmcutler merged 2 commits intomainfrom
fix-auto-open

Conversation

@lavalleeale
Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

Before this nothing in submissions_processed would be considered for auto open and pdfs would be opened by default

What is the New Behavior?

Files in submissions_processed are considered for auto open and pngs would be opened by default.

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Create a bulk upload for an exam
  2. Create components assigned to specific pages
  3. Open the components and see what gets opened on main vs this pr

Automated Testing & Documentation

Other information

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.69%. Comparing base (02d3aed) to head (a0fe669).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12127   +/-   ##
=========================================
  Coverage     21.69%   21.69%           
  Complexity     9585     9585           
=========================================
  Files           268      268           
  Lines         36591    36591           
  Branches        475      475           
=========================================
  Hits           7940     7940           
  Misses        28180    28180           
  Partials        471      471           
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.07% <0.00%> (ø)
migrator 100.00% <ø> (ø)
php 20.71% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@Rkoester47 Rkoester47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After bulk uploading PDFs for an exam and creating components on different pages, I was able to test the auto-open for each individual problem in the grading area. The changes to the code are efficient, and as far as I can tell have successfully resolved the issue. When I click to open a given problem, the png automatically reopens by default. As far as I can tell, the issue is resolved and the new behavior matches the expected new behavior from the PR description.

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Oct 3, 2025
@bmcutler bmcutler merged commit 58d2ede into main Oct 3, 2025
24 of 27 checks passed
@bmcutler bmcutler deleted the fix-auto-open branch October 3, 2025 21:23
Copy link
Copy Markdown
Contributor

@RyanStyron RyanStyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions properly as described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants