[Bugfix:RainbowGrades] Save Gradeables Configurations#12126
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12126 +/- ##
=========================================
Coverage 21.73% 21.74%
- Complexity 9598 9605 +7
=========================================
Files 268 268
Lines 36006 36019 +13
Branches 475 475
=========================================
+ Hits 7827 7832 +5
- Misses 27708 27716 +8
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rkoester47
left a comment
There was a problem hiding this comment.
I tested the changes here in the Rainbow Grades Configuration, and was able to reproduce all of the features listed in the PR. The category/ gradeable section does have two toggle buttons now.
Also, I was able to test both attempting to remove "drop lowest" while a number of lowest drops were specified, as well as removing "per gradeable percents" while having at least one grade be worth a different amount than the others. In both cases, the warning did pop up to let me know that I could not make those changes to the configuration.
Overall, the changes to the site match the PR and have improved the functionality of the gradeable configuration tools. The new functionality is more intuitive and in-line with what someone configuring a gradeable should expect.
…dit value in ReportControllerTester.
…eables-settings-nonsticky-fix
lavalleeale
left a comment
There was a problem hiding this comment.
I tested locally and can confirm the bugs listed in the PR description are fixed and for someone not familiar with configuring rainbow grades it makes a lot more sense to me now
…eables-settings-nonsticky-fix
|
Added a toggle for the configuration settings via the pencil icon. By default, the configuration settings, including individual per gradeable percents and bucket-level "remove lowest" values, are hidden, but when the pencil is clicked, the configurations become visible. |
…eables-settings-nonsticky-fix
Rkoester47
left a comment
There was a problem hiding this comment.
All of the updates and UI changes since my initial approval look clean and help improve site readability and usability.
lavalleeale
left a comment
There was a problem hiding this comment.
This definitely works as intended, but as a new rainbow grades user, having to click the pencil to view the settings make it very hard for a new user to know that more settings are there
…eables-settings-nonsticky-fix
…eables-settings-nonsticky-fix
lavalleeale
left a comment
There was a problem hiding this comment.
The code and the experience are both very good now, the bugs are fixed and the UI is a lot easier to understand
Why is this Change Important & Necessary?
There are currently three toggles in the
Category/Gradeable Configurationsection of theGrades Configurationpage:Extra credit,Remove lowest, andPer Gradeable Percents(displayed below). These toggles do not currently save after being changed; most problematic is that per gradeable percentages are not retrieved properly. Further, there is a lack of intuition with respect to certain toggles in that, for instance, an instructor can assign a "remove lowest" value, and then disable the "remove lowest" toggle, but the value would retain its pre-disabled value and applied as such rather than being assigned to zero. This applies to per gradeable percentages as well. As opposed to "per gradeables percent" having both a global and local toggle (with respect to a given course's settings), it seems more logical to have them isolated purely as gradeable-specific. Similarly, disabling a per gradeable percentage should be disabled (coupled with an attached error message) unless all gradeables have equal weightings; same logic for remove lowest toggling.What is the New Behavior?
Initial view:
Update view:
What steps should a reviewer take to reproduce or test the bug or new feature?
As an instructor, navigate to
Grades Configurationof a course and apply various toggles and values to respective configurations.Automated Testing & Documentation
Other information