Skip to content

[Bugfix:TAGrading] Show autograding stats before TAGrading#12085

Merged
bmcutler merged 2 commits intomainfrom
autograded-only-stats
Oct 2, 2025
Merged

[Bugfix:TAGrading] Show autograding stats before TAGrading#12085
bmcutler merged 2 commits intomainfrom
autograded-only-stats

Conversation

@lavalleeale
Copy link
Contributor

Why is this Change Important & Necessary?

Currently if a gradeable has autograding but no tagrading or autograding with unfinished tagrading, student that do not have tagrading data will not be included in autograding statistics.

What is the New Behavior?

Any student with autograding outside of the null section will be included in autograding statistics.

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Submit to a gradeable with autograding on main (I used tutorial 01)
  2. Notice that the autograding statistics do not change
  3. View on branch

Automated Testing & Documentation

Other information

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.69%. Comparing base (e8d4cd0) to head (e0f85f3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12085   +/-   ##
=========================================
  Coverage     21.69%   21.69%           
+ Complexity     9587     9585    -2     
=========================================
  Files           268      268           
  Lines         36593    36591    -2     
  Branches        475      475           
=========================================
  Hits           7940     7940           
+ Misses        28182    28180    -2     
  Partials        471      471           
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.07% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.71% <0.00%> (+<0.01%) ⬆️
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Rkoester47 Rkoester47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I signed in as student on the main branch, uploaded a submission to tutorial 01, and then signed in as instructor on the main branch. As expected, there was no auto grading histogram available for this submission, presumably because there was no TA grading yet.

Then, I repeated the above steps on the autograded-only-stats branch and the issue appears to be resolved. After submitting to tutorial 01 as student, I was able to see the auto grading histogram when signed in as the instructor, even though there was still no TA grading.

The changes to the code are efficient and do appear to have resolved the issue as far as my testing shows.

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Sep 30, 2025
@bmcutler bmcutler merged commit 02d3aed into main Oct 2, 2025
22 of 25 checks passed
@bmcutler bmcutler deleted the autograded-only-stats branch October 2, 2025 01:06
@github-project-automation github-project-automation bot moved this from Awaiting Maintainer Review to Done in Submitty Development Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants