Skip to content

[Bugfix:Developer] Fix Sidebar Cypress Test#12078

Merged
bmcutler merged 1 commit intomainfrom
sidebar-fix
Oct 2, 2025
Merged

[Bugfix:Developer] Fix Sidebar Cypress Test#12078
bmcutler merged 1 commit intomainfrom
sidebar-fix

Conversation

@IDzyre
Copy link
Member

@IDzyre IDzyre commented Sep 24, 2025

Why is this Change Important & Necessary?

Currently, the sidebar cypress test fails on main due to a cypress version mismatch with an external plugin.
Before, in this situation we were using 'attachFile' which is from an external plugin.

What is the New Behavior?

Now, we are using the built-in function 'selectFile' which uses a different location, but it's easily changed.

What steps should a reviewer take to reproduce or test the bug or new feature?

Mainly, just review the code, and check that the tests are now passing in CI.

Other information

This will fix one of the many failing tests in Main.

@github-project-automation github-project-automation bot moved this to Seeking Reviewer in Submitty Development Sep 24, 2025
@automateprojectmangement automateprojectmangement bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Sep 24, 2025
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.69%. Comparing base (e8d4cd0) to head (d546495).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12078   +/-   ##
=========================================
  Coverage     21.69%   21.69%           
  Complexity     9587     9587           
=========================================
  Files           268      268           
  Lines         36593    36593           
  Branches        475      475           
=========================================
  Hits           7940     7940           
  Misses        28182    28182           
  Partials        471      471           
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.07% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.71% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IDzyre IDzyre marked this pull request as ready for review September 24, 2025 05:53
@automateprojectmangement automateprojectmangement bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Sep 24, 2025
Copy link
Contributor

@JManion32 JManion32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on production and local Cypress.

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Sep 26, 2025
@IDzyre IDzyre moved this from Awaiting Maintainer Review to Ready to Merge in Submitty Development Sep 26, 2025
@bmcutler bmcutler merged commit ebada1f into main Oct 2, 2025
27 of 28 checks passed
@bmcutler bmcutler deleted the sidebar-fix branch October 2, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants