[Bugfix:Autograding] system calls on pdf_notes_page gradeables#12077
Merged
[Bugfix:Autograding] system calls on pdf_notes_page gradeables#12077
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12077 +/- ##
=========================================
Coverage 21.69% 21.69%
Complexity 9587 9587
=========================================
Files 268 268
Lines 36593 36593
Branches 475 475
=========================================
Hits 7940 7940
Misses 28182 28182
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
The list of allowed systems calls for pdflatex on the notes page gradeables needs to be updated.
What is the New Behavior?
Before the change, the pdf in testcase #2 containing the instructor 'exam' with the student notes attached was not viewable.
The pdf was not produced/was corrupted because a system call was failing during one of the pdf processing steps.
After the change, the pdf is viewable.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
We should continue to add more automated testing of these gradeables.
Other information