[Bugfix:InstructorUI] Simple Gradeable Checkpoint Fix#12075
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12075 +/- ##
=========================================
Coverage 21.69% 21.69%
Complexity 9587 9587
=========================================
Files 268 268
Lines 36593 36593
Branches 475 475
=========================================
Hits 7940 7940
Misses 28182 28182
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rkoester47
left a comment
There was a problem hiding this comment.
I tested the changes in Firefox, Chrome and Edge. Additionally, I checked to make sure that both light and dark mode present the changes as intended. All of my tests showed the page just as the intended look, shown by the New Behavior photo in the PR.
It seems that the issue was resolved, the Simple Gradeable Checkpoint colors extend to the full box and look much cleaner now. The edits to the code seem efficient and understandable as a way to fix the styling issue on this page.
This fix shows a clear improvement to this particular page of the site.
Why is this Change Important & Necessary?
#12062 fixed the key, but broke simple gradeable checkpoints since they shared the same CSS classes.
What is the New Behavior?
Separated the CSS classes of the key and the checkpoint buttons.
What steps should a reviewer take to reproduce or test the bug or new feature?
Go to sample --> Grades Released Lab --> Make sure the page looks normal
Other information
This is not a breaking change.