[Bugfix:Forum] Fix Markdown Toggle on Forum Replies#12071
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12071 +/- ##
=========================================
Coverage 21.69% 21.69%
Complexity 9587 9587
=========================================
Files 268 268
Lines 36593 36593
Branches 475 475
=========================================
Hits 7940 7940
Misses 28182 28182
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JManion32
left a comment
There was a problem hiding this comment.
There seems to still be an issue with the edit box where the content of edited messages are deleted when preview or markdown is toggled.
buggy-markdown-fix-video.mp4
Rkoester47
left a comment
There was a problem hiding this comment.
I tested to see if I could reproduce the issue Justin showed in the video above, and I believe the same issue is present for me. While I can use markdown toggle on a new comment to add a hyperlink, I can confirm that attempting to edit an existing comment and toggling the markdown or preview erases the message entirely.
Hitting cancel also replaces the text in the comment in the thread.
Rkoester47
left a comment
There was a problem hiding this comment.
I initially tested an out of date version. After checking the newest commits, the issue does seem to be resolved. I was able to edit a comment, toggle markdown and preview with no issue.
JManion32
left a comment
There was a problem hiding this comment.
Toggling markdown and preview work correctly while preserving the content of the post.
Why is this Change Important & Necessary?
Resolves #12068
Markdown toggle on Forum replies does not function correctly (see issue for more details).
Also, toggling markdown may erase the contents of the text box in certain cases.
Bug introduced by Vue refactor #11872
What is the New Behavior?
Vue component has been updated to directly read+write to original HTML form input, removed unnecessary cookie
Markdown fields without toggle functionality are preserved
It is worth investigating to find a better solution for propagating Vue state updates to outer DOM in the future.