[Feature:Notifications] Removed Late Days in Title#12069
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12069 +/- ##
=========================================
Coverage 21.69% 21.69%
Complexity 9587 9587
=========================================
Files 268 268
Lines 36591 36591
Branches 475 475
=========================================
Hits 7940 7940
Misses 28180 28180
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
bmcutler
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Submissions Open notifications feature student's remaining, and allowed late days. This extra information makes the title of these types of notifications long, reducing readability for the user.
What is the New Behavior?
Removed the late days from the title of notifications (it is still in the body).
Old
New
What steps should a reviewer take to reproduce or test the bug or new feature?
submitty_installsince it is a change in the scriptssudo -u "submitty_daemon" python3 sbin/send_notification.py, this will send the notificationOther information
This is not a breaking change, this PR could also address all forum notifications saying "New Announcement", if we think we want to change that.