[Bugfix:InstructorUI] Notebook Permissions fix#12060
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12060 +/- ##
============================================
- Coverage 21.70% 21.70% -0.01%
- Complexity 9582 9584 +2
============================================
Files 268 268
Lines 36560 36565 +5
Branches 475 475
============================================
Hits 7936 7936
- Misses 28153 28158 +5
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
On our production system, the TA's group is
course_<courseName>_tas_www, but the notebook builder expects<courseName>_tas_www. In addition to not being able to make new notebook gradeables on the course, the permissions if we were to make the gradeables would be wrong as well, as the group would not exist.What is the New Behavior?
Uses a more dynamic method of determining the group. I cannot find a better solution than looking at the config file.
What steps should a reviewer take to reproduce or test the bug or new feature?
https://submitty.org/sysadmin/configuration/course_creation
Make the group
course_<courseName>_tas_www. Make the course just . See the error. See that it fixed with this PRAutomated Testing & Documentation
We do not have testing that test command line method of creating courses and users.
Other information