[Bugfix:InstructorUI] Fix Config Editor Text Color#12059
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12059 +/- ##
=========================================
Coverage 21.70% 21.70%
Complexity 9582 9582
=========================================
Files 268 268
Lines 36560 36560
Branches 475 475
=========================================
Hits 7936 7936
Misses 28153 28153
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Firefox users on MacOS were reporting text color in the gradeable config editor having no contrast against the background in light mode. I was unable to replicate the bug on Windows Firefox, but I believe this could be due to the color not being explicitly set in the text area's CSS.
What is the New Behavior?
Text color is now explicitly set for the gradeable config editor.
What steps should a reviewer take to reproduce or test the bug or new feature?
Verify that the gradeable text area has readable text colors on different browsers and themes.
Other information
Since I can't test it, I used an instance of
!importantto make sure the issue is resolved, but this may not be necessary.