[Bugfix:Developer] Optional Notebook Elements Fix#12016
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12016 +/- ##
=========================================
Coverage 21.70% 21.70%
Complexity 9582 9582
=========================================
Files 268 268
Lines 36560 36560
Branches 475 475
=========================================
Hits 7936 7936
Misses 28153 28153
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
thegame615
approved these changes
Sep 2, 2025
Contributor
thegame615
left a comment
There was a problem hiding this comment.
I am not familiar with the original errors, but it seems to work error free
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
If an instructor uploads a notebook that has an image that has a defined height or width, then an image that does have a defined heigth or width, it will be fine on production but when we get to a developer environment, there will a lot of errors because of strict_type.
What is the New Behavior?
This PR aims to check if optional elements exists and then apply them if possible
What steps should a reviewer take to reproduce or test the bug or new feature?
Redacted psoft to see error
Archive.zip
Automated Testing & Documentation
N/A
Other information