Skip to content

[Bugfix:Autograding] Render Jupyter Notebook TypeError#12013

Merged
bmcutler merged 1 commit intomainfrom
notebook-frog
Aug 19, 2025
Merged

[Bugfix:Autograding] Render Jupyter Notebook TypeError#12013
bmcutler merged 1 commit intomainfrom
notebook-frog

Conversation

@Chriun
Copy link
Contributor

@Chriun Chriun commented Aug 18, 2025

Why is this Change Important & Necessary?

This change is necessary because it fixes a TypeError that occurs when trying to render a Jupyter Notebook with a cell source that is only a string and not a list.

What is the New Behavior?

Rendering the notebook should now successfully account for a string source, as it did prior to #11891.

Before
image

After
Notebook successfully renders.

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Reviewer can modify an existing notebook example metadata such that a cell's source attribute is a string.
  2. Create any gradeable.
  3. Submit the modified notebook example.
  4. View rendered example via popup.

Automated Testing & Documentation

No tests needed for UI.

Other information

@github-project-automation github-project-automation bot moved this to Seeking Reviewer in Submitty Development Aug 18, 2025
@Chriun Chriun marked this pull request as ready for review August 18, 2025 17:49
@automateprojectmangement automateprojectmangement bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Aug 18, 2025
@automateprojectmangement automateprojectmangement bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Aug 18, 2025
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 21.68%. Comparing base (3d42bd3) to head (85ba2f4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #12013      +/-   ##
============================================
+ Coverage     21.66%   21.68%   +0.01%     
- Complexity     9528     9531       +3     
============================================
  Files           268      257      -11     
  Lines         36395    34448    -1947     
  Branches        475      475              
============================================
- Hits           7886     7471     -415     
+ Misses        28038    26506    -1532     
  Partials        471      471              
Flag Coverage Δ
autograder ?
js 2.07% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.67% <0.00%> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@bmcutler bmcutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I tested and this has solved the problem we had on our production server.

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Aug 19, 2025
@bmcutler bmcutler merged commit db9d942 into main Aug 19, 2025
50 of 51 checks passed
@bmcutler bmcutler deleted the notebook-frog branch August 19, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants