Skip to content

[Bugfix:InstructorUI] Bulk upload toast fix#12009

Merged
bmcutler merged 1 commit intomainfrom
fix-bulk-upload-toasts
Aug 18, 2025
Merged

[Bugfix:InstructorUI] Bulk upload toast fix#12009
bmcutler merged 1 commit intomainfrom
fix-bulk-upload-toasts

Conversation

@williamschen23
Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

#11857, we replace all the toasts with vue. however, there was still some places where jquery calls #messages which could desync the vue files content. This causes a very weird error,

    TypeError: Cannot read properties of null (reading 'insertBefore')
    at insert (vue.runtime.global.prod.js?v=1755186796:6:53704)
    at O (vue.runtime.global.prod.js?v=1755186796:6:10185)
    at R (vue.runtime.global.prod.js?v=1755186796:6:9733)
    at C (vue.runtime.global.prod.js?v=1755186796:6:9199)
    at Y (vue.runtime.global.prod.js?v=1755186796:6:18714)
    at G (vue.runtime.global.prod.js?v=1755186796:6:17988)
    at U (vue.runtime.global.prod.js?v=1755186796:6:12056)
    at C (vue.runtime.global.prod.js?v=1755186796:6:9160)
    at F (vue.runtime.global.prod.js?v=1755186796:6:11493)
    at D (vue.runtime.global.prod.js?v=1755186796:6:10902)

which does not really make sense. This is because of the desync between js and vue.

What is the New Behavior?

This removes allof the references to #messages, which causes the bulk upload page to have the notifications.

What steps should a reviewer take to reproduce or test the bug or new feature?

Make an error on the page, like entering a page count that is too large, and click bulk upload. Nothing should show up, but there should be notifications after viewing this PR

Automated Testing & Documentation

Other information

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.66%. Comparing base (7fbcef5) to head (8e67f9f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12009   +/-   ##
=========================================
  Coverage     21.66%   21.66%           
  Complexity     9528     9528           
=========================================
  Files           268      268           
  Lines         36395    36395           
  Branches        475      475           
=========================================
  Hits           7886     7886           
  Misses        28038    28038           
  Partials        471      471           
Flag Coverage Δ
autograder 21.31% <ø> (ø)
js 2.07% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.67% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@JManion32 JManion32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TypeError no longer occurs with this PR.

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Aug 16, 2025
@bmcutler bmcutler merged commit 3d42bd3 into main Aug 18, 2025
71 of 73 checks passed
@bmcutler bmcutler deleted the fix-bulk-upload-toasts branch August 18, 2025 16:05
@github-project-automation github-project-automation bot moved this from Awaiting Maintainer Review to Done in Submitty Development Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants