[Bugfix:InstructorUI] Bulk upload toast fix#12009
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12009 +/- ##
=========================================
Coverage 21.66% 21.66%
Complexity 9528 9528
=========================================
Files 268 268
Lines 36395 36395
Branches 475 475
=========================================
Hits 7886 7886
Misses 28038 28038
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JManion32
approved these changes
Aug 16, 2025
Contributor
JManion32
left a comment
There was a problem hiding this comment.
The TypeError no longer occurs with this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
#11857, we replace all the toasts with vue. however, there was still some places where jquery calls
#messageswhich could desync the vue files content. This causes a very weird error,which does not really make sense. This is because of the desync between js and vue.
What is the New Behavior?
This removes allof the references to
#messages, which causes the bulk upload page to have the notifications.What steps should a reviewer take to reproduce or test the bug or new feature?
Make an error on the page, like entering a page count that is too large, and click bulk upload. Nothing should show up, but there should be notifications after viewing this PR
Automated Testing & Documentation
Other information