Skip to content

[Feature:Autograding] Add regrade_by to autograding history#12006

Merged
bmcutler merged 7 commits intomainfrom
add-regrade-to-quee
Sep 8, 2025
Merged

[Feature:Autograding] Add regrade_by to autograding history#12006
bmcutler merged 7 commits intomainfrom
add-regrade-to-quee

Conversation

@williamschen23
Copy link
Copy Markdown
Contributor

@williamschen23 williamschen23 commented Aug 14, 2025

Why is this Change Important & Necessary?

Whenever we click regrade, we have no idea who the submission has been graded by. If we want to include students regrading, we should have an idea of who regraded the submission. Therefore, we should add this in the queue file, which adds it to the history file.

What is the New Behavior?

Adds the user who regrades into the queue and history file

What steps should a reviewer take to reproduce or test the bug or new feature?

Make sure that autograding does not break. I have tested team, vcs, and notebook submissions. I have also verified that the history with regrade_by is written to the file.

Automated Testing & Documentation

Unit tests are included. E2E tests would still have to be written.

Other information

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 21.71%. Comparing base (3e4ac5b) to head (e5d8992).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #12006      +/-   ##
============================================
+ Coverage     21.66%   21.71%   +0.04%     
- Complexity     9528     9582      +54     
============================================
  Files           268      268              
  Lines         36398    36563     +165     
  Branches        475      475              
============================================
+ Hits           7886     7938      +52     
- Misses        28041    28154     +113     
  Partials        471      471              
Flag Coverage Δ
autograder 21.39% <100.00%> (+0.08%) ⬆️
js 2.07% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.72% <0.00%> (+0.05%) ⬆️
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@JManion32 JManion32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran recreate_sample_courses on this PR and let the autograding queue run. This was the only error that occurred, and it looks unrelated:

image

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Aug 16, 2025
@bmcutler
Copy link
Copy Markdown
Member

@williamschen23

I didn't test this, but do you also correctly handle (the original) regrade from the command line:
https://submitty.org/instructor/autograding/batch_regrade
(I don't see any edits to the regrade.py script)

And have we also tested vcs & team submissions (so many options to test). Please update your notes in the PR message about all of the different types of gradeable you have tested this on.

Thanks!

@bmcutler bmcutler self-requested a review August 18, 2025 16:10
@automateprojectmangement automateprojectmangement bot moved this from Awaiting Maintainer Review to In Review in Submitty Development Aug 18, 2025
@bmcutler bmcutler merged commit 2bac9f6 into main Sep 8, 2025
47 of 48 checks passed
@bmcutler bmcutler deleted the add-regrade-to-quee branch September 8, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants