Skip to content

[Feature:TAGrading] Withdrawn Student Banner#12005

Merged
bmcutler merged 1 commit intomainfrom
withdrawn-student-banner
Aug 14, 2025
Merged

[Feature:TAGrading] Withdrawn Student Banner#12005
bmcutler merged 1 commit intomainfrom
withdrawn-student-banner

Conversation

@williamschen23
Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

There is currently no way for a TA to distinguish who is a withdrawn student or not. If they navigate using the navigating button, they might accidentally grade a withdrawn student, who doesn't actually need grading.

What is the New Behavior?

This PR aims to add banners to distinguish the withdrawn status. In addition, this slightly fixes a bug where a overridden student submits to a gradeable and the text not appearing on the rubric panel.

image

What steps should a reviewer take to reproduce or test the bug or new feature?

Automated Testing & Documentation

#11882 will add withdrawn students, then it would be easier to test

Other information

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.66%. Comparing base (199db02) to head (b2151b7).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #12005      +/-   ##
============================================
- Coverage     21.70%   21.66%   -0.04%     
- Complexity     9495     9528      +33     
============================================
  Files           268      268              
  Lines         36298    36398     +100     
  Branches        474      475       +1     
============================================
+ Hits           7878     7886       +8     
- Misses        27950    28041      +91     
- Partials        470      471       +1     
Flag Coverage Δ
autograder 21.31% <ø> (ø)
js 2.07% <ø> (-0.01%) ⬇️
migrator 100.00% <ø> (ø)
php 20.67% <ø> (-0.04%) ⬇️
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jeffrey-cordero jeffrey-cordero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overridden grades and withdrawn students' notice banner correctly displays for the applicable students to prevent graders from unnecessary grading. #11882 should add the respective tests within student_info_panel.spec.js once this is merged.

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Aug 14, 2025
@bmcutler bmcutler merged commit dec8f60 into main Aug 14, 2025
49 of 50 checks passed
@bmcutler bmcutler deleted the withdrawn-student-banner branch August 14, 2025 18:08
@github-project-automation github-project-automation bot moved this from Awaiting Maintainer Review to Done in Submitty Development Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants