[Testing:Developer] Explicit fail on cypress unmet condition#12004
Merged
[Testing:Developer] Explicit fail on cypress unmet condition#12004
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12004 +/- ##
============================================
- Coverage 21.70% 21.66% -0.04%
- Complexity 9495 9528 +33
============================================
Files 268 268
Lines 36298 36398 +100
Branches 474 475 +1
============================================
+ Hits 7878 7886 +8
- Misses 27950 28041 +91
- Partials 470 471 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jeffrey-cordero
approved these changes
Aug 14, 2025
Contributor
jeffrey-cordero
left a comment
There was a problem hiding this comment.
Additional error checking within the existing cy.waitAndReloadUntil command looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
DockerUI has been failing rarely now. I cannot debug the issue successfully, but I did notice that there was some discrency in the tests. This is because the dockerui checks the docker status, but that could fail in the previous test. When we use
cy.waitAndReloadUntil, we do not really fail if the condition fails to be met. This causes the CI to fail in general.What is the New Behavior?
This explicitly fails if our condition is never met. Otherwise, the test runs as usual.
What steps should a reviewer take to reproduce or test the bug or new feature?
This grabs something that does not exist. Originally the behavior would be that the test passed. With the newbehavior, an error is correctly thrown
Automated Testing & Documentation
Other information
The dockerui might need other work