[Refactor:TAGrading] Move solution notes to vue#11885
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11885 +/- ##
=============================================
- Coverage 88.88% 21.74% -67.15%
- Complexity 0 9332 +9332
=============================================
Files 9 268 +259
Lines 531 35829 +35298
Branches 0 471 +471
=============================================
+ Hits 472 7791 +7319
- Misses 59 27571 +27512
- Partials 0 467 +467
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jeffrey-cordero
requested changes
Jul 25, 2025
Contributor
jeffrey-cordero
left a comment
There was a problem hiding this comment.
The overall approach to migrating the solutions panel to Vue is solid, especially as it resolves several existing issues on the main branch, but a few adjustments are still needed.
jeffrey-cordero
approved these changes
Jul 28, 2025
Contributor
jeffrey-cordero
left a comment
There was a problem hiding this comment.
The refactor to move the solutions panel into a native Vue component looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
This moves the first tagrading panel to vue.
What is the New Behavior?
Solution notes is rendered with vue and the twig + separate scripts are removed.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
Other information
This is meant to be merged after #11872