[Feature:TAGrading] Withdrawn student grading toggle#11879
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11879 +/- ##
=========================================
Coverage 21.68% 21.68%
- Complexity 9494 9512 +18
=========================================
Files 267 268 +1
Lines 36286 36326 +40
Branches 474 475 +1
=========================================
+ Hits 7869 7879 +10
- Misses 27947 27976 +29
- Partials 470 471 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
This PR successfully makes it so that the withdrawn toggle impacts the color of the gradable button |
martig7
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
closes #11874
We are automatically including the withdrawn student in the grading statistics, leading to incomplete ta results. More could be read in the issue above. We want a toggle that automatically hides all the withdrawn students so we can grade all the "active" students.
What is the New Behavior?
Synced the two cookies to
include_withdrawn_studentsMade the statistics correct based on if we are hiding or showing withdrawn students.
What steps should a reviewer take to reproduce or test the bug or new feature?
Make sure that teams and user gradeables both work. Make sure the code is consistent and that each stat changes with cookie changes. Make sure that team gradeable stats don't change.
Automated Testing & Documentation
#11763 starts with adding withdrawn students. The tests will be added after that.
Other information