Skip to content

Rewrite CONFIGURE_SUBMITTY.sh into python#1177

Merged
bmcutler merged 24 commits intomasterfrom
configure
Jul 13, 2017
Merged

Rewrite CONFIGURE_SUBMITTY.sh into python#1177
bmcutler merged 24 commits intomasterfrom
configure

Conversation

@MasterOdin
Copy link
Member

@MasterOdin MasterOdin commented Jul 9, 2017

Continues on #918 by porting over CONFIGURE_SUBMITTY.sh. It's currently left in the code base until I've had more people test out the script to make sure there was no bugs introduced.

I also took this occasion to rewrite the log directory structure to close #1012 and enable specifying the authentication method to close #1145.

This additionally gives defaults when asking for input and will reuse the previously entered answers (if available).

@MasterOdin MasterOdin requested a review from bmcutler July 9, 2017 21:58
# Log locations
TAGRADING_LOG_PATH=$SUBMITTY_DATA_DIR/tagrading_logs/
AUTOGRADING_LOG_PATH=$SUBMITTY_DATA_DIR/autograding_logs/
TAGRADING_LOG_PATH=$SUBMITTY_DATA_DIR/logs/site/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the "site" folder?
I suggest:
/var/local/submitty/logs/autograding
/var/local/submitty/logs/access
/var/local/submitty/logs/error

@bmcutler
Copy link
Member

(got lost when I removed CONFIGURE_SUBMITTY.sh)

Do we need the "site" folder?
I suggest:
/var/local/submitty/logs/autograding
/var/local/submitty/logs/access
/var/local/submitty/logs/error

@MasterOdin
Copy link
Member Author

MasterOdin commented Jul 11, 2017

I'd say yes as just "error" or "access" is not clear what it might contain. Should it also contain errors from the autograder? How about errors from rainbow grades? Etc.

Unless we plan to start putting more component logs into these folders in which case then yes, we'd flatten the directory structure out a bit.

@bmcutler
Copy link
Member

autograding & access are logs of normal activity at the system level. We might introduce other normal activity logs later. Autograding logs do contain some error messages within the log -- and I argue those specific errors should stay where they are.

The error log should be empty, if things are debugged and not malfunctioning. When things start malfunctioning, yes, I think all sorts of detailed errors could be written to that directory -- as a combined log or as separate files, whatever makes sense.

bmcutler
bmcutler previously approved these changes Jul 11, 2017
@bmcutler
Copy link
Member

The autograding logs folder contains info allowing the sysadmin to monitor machine load. Instructors generally don't use this to debug. Rather they use the logs per assignment in their course directory.

The rainbow grades errors contain confidential info that should not be at the system level, but rather per course, so the instructor can get in there are tinker as needed.

@MasterOdin
Copy link
Member Author

MasterOdin commented Jul 13, 2017

@bmcutler So I've made the following changes to this:

  1. flatten sites/* to be site_errors/ and access/
  2. have CONFIGURE_SUBMITTY.py write out a JSON file with all answers
  3. Have CONFIGURE_SUBMITTY.py supply the user with defaults with those defaults being the previously set configuration if file was loaded (so for rerunning CONFIGURE on the live server will just be hitting enter a bunch of times).

Once Travis finishes, I'm going to merge this, and we can address further concerns in new issues (like maybe add new flag to not even bother asking questions if the system already has the answers in the saved submitty_conf.json file).

@bmcutler bmcutler merged commit 6d2bb12 into master Jul 13, 2017
@MasterOdin MasterOdin deleted the configure branch July 17, 2017 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add question to CONFIGURE_SUBMITTY.sh about authentication method Change "tagrading_logs" to be "site_logs"

2 participants