[Refactor:SubminiPolls] Move poll access to Access.php#11638
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11638 +/- ##
============================================
- Coverage 21.04% 20.69% -0.35%
- Complexity 9077 9182 +105
============================================
Files 258 263 +5
Lines 34866 35228 +362
Branches 461 461
============================================
- Hits 7337 7290 -47
- Misses 27072 27481 +409
Partials 457 457
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
williamjallen
requested changes
May 30, 2025
Member
williamjallen
left a comment
There was a problem hiding this comment.
A few brief stylistic comments, otherwise looks reasonable to me.
Co-authored-by: William Allen <16820599+williamjallen@users.noreply.github.com>
williamjallen
approved these changes
Jun 13, 2025
Member
williamjallen
left a comment
There was a problem hiding this comment.
Code seems reasonable to me.
williamjallen
requested changes
Jun 13, 2025
Member
williamjallen
left a comment
There was a problem hiding this comment.
As discussed in the meeting today, let's add a unit test for this before merge.
williamjallen
approved these changes
Jun 27, 2025
Member
williamjallen
left a comment
There was a problem hiding this comment.
Thanks for adding a unit test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
What is the current behavior?
When viewing a poll, the authorization logic is handled within the polls controller which makes it inaccessible to anywhere else in the codebase that might need to verify if a user should have access to a poll.
What is the new behavior?
The logic is moved to Access.php under
poll.viewandpoll.view.histogramOther information?
Needed for #11634