[Dependency] Bump watchdog from 4.0.1 to 6.0.0 in /.setup/pip by dependabot[bot] · Pull Request #11114 · Submitty/Submitty

dependabot · 2024-11-01T19:00:02Z

Bumps watchdog from 4.0.1 to 6.0.0.

Release notes

6.0.0

Breaking Changes

[inotify] Use of select.poll() instead of deprecated select.select(), if available. (#1078)

[utils] Removed the unused echo_class() function from the echo module.

[utils] Removed the unused echo_instancemethod() function from the echo module.

[utils] Removed the unused echo_module() function from the echo module.

[utils] Removed the unused is_class_private_name() function from the echo module.

[utils] Removed the unused is_classmethod() function from the echo module.

[utils] Removed the unused ic_method(met() function from the echo module.

[utils] Removed the unused method_name() function from the echo module.

[utils] Removed the unused name() function from the echo module.

[watchmedo] Removed the --trace CLI argument from the watchmedo log command, useless since events are logged by default at the LoggerTrick class level.

Other CHanges

Pin test dependecies.

[docs] Add typing info to quick start. (#1082)

[inotify] Fix reading inotify file descriptor after closing it. (#1081)

[utils] The stop_signal keyword-argument type of the AutoRestartTrick class can now be either a signal.Signals or an int.

[utils] Added the __repr__() method to the Trick class.

[watchmedo] Fixed Mypy issues.

[watchmedo] Added the __repr__() method to the HelpFormatter class.

[windows] Fixed Mypy issues.

💟 Thanks to our beloved contributors: @g-pichler, @ethan-vanderheijden, @nhairs, @BoboTiG

5.0.3

[inotify] Improve cleaning up Inotify threads, and add eventlet test cases (#1070)

💟 Thanks to our beloved contributors: @ethan-vanderheijden, @BoboTiG

5.0.2

Enable OS specific Mypy checks (#1064)

[watchmedo] Fix tricks argument type of schedule_tricks() (#1063)

💟 Thanks to our beloved contributors: @gnought, @BoboTiG

5.0.1

[kqueue] Fix TypeError: kqueue.control() only accepts positional parameters (#1062)

💟 Thanks to our beloved contributors: @apoirier, @BoboTiG

5.0.0

Breaking Changes

Drop support for Python 3.8 (#1055)

[core] Enforced usage of proper keyword-arguments (#1057)

[core] Renamed the BaseObserverSubclassCallable class to ObserverType (#1055)

[inotify] Renamed the inotify_event_struct class to InotifyEventStruct (#1055)

... (truncated)

Changelog

Sourced from watchdog's changelog.

6.0.0


2024-11-01 • `full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.3...v6.0.0>`__

Pin test dependecies.
[docs] Add typing info to quick start. ([#1082](https://github.com/gorakhargosh/watchdog/issues/1082) &lt;https://github.com/gorakhargosh/watchdog/pull/1082&gt;__)
[inotify] Use of select.poll() instead of deprecated select.select(), if available. ([#1078](https://github.com/gorakhargosh/watchdog/issues/1078) &lt;https://github.com/gorakhargosh/watchdog/pull/1078&gt;__)
[inotify] Fix reading inotify file descriptor after closing it. ([#1081](https://github.com/gorakhargosh/watchdog/issues/1081) &lt;https://github.com/gorakhargosh/watchdog/pull/1081&gt;__)
[utils] The stop_signal keyword-argument type of the AutoRestartTrick class can now be either a signal.Signals or an int.
[utils] Added the __repr__() method to the Trick class.
[utils] Removed the unused echo_class() function from the echo module.
[utils] Removed the unused echo_instancemethod() function from the echo module.
[utils] Removed the unused echo_module() function from the echo module.
[utils] Removed the unused is_class_private_name() function from the echo module.
[utils] Removed the unused is_classmethod() function from the echo module.
[utils] Removed the unused ic_method(met() function from the echo module.
[utils] Removed the unused method_name() function from the echo module.
[utils] Removed the unused name() function from the echo module.
[watchmedo] Fixed Mypy issues.
[watchmedo] Added the __repr__() method to the HelpFormatter class.
[watchmedo] Removed the --trace CLI argument from the watchmedo log command, useless since events are logged by default at the LoggerTrick class level.
[windows] Fixed Mypy issues.
Thanks to our beloved contributors: @BoboTiG, @g-pichler, @ethan-vanderheijden, @nhairs

5.0.3

2024-09-27 • full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.2...v5.0.3>__

[inotify] Improve cleaning up Inotify threads, and add eventlet test cases ([#1070](https://github.com/gorakhargosh/watchdog/issues/1070) <https://github.com/gorakhargosh/watchdog/pull/1070>__)
Thanks to our beloved contributors: @BoboTiG, @ethan-vanderheijden

5.0.2


2024-09-03 • `full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.1...v5.0.2>`__

Enable OS specific Mypy checks ([#1064](https://github.com/gorakhargosh/watchdog/issues/1064) &lt;https://github.com/gorakhargosh/watchdog/pull/1064&gt;__)
[watchmedo] Fix tricks argument type of schedule_tricks() ([#1063](https://github.com/gorakhargosh/watchdog/issues/1063) &lt;https://github.com/gorakhargosh/watchdog/pull/1063&gt;__)
Thanks to our beloved contributors: @gnought, @BoboTiG

5.0.1

2024-09-02 • full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.0...v5.0.1>__

[kqueue] Fix TypeError: kqueue.control() only accepts positional parameters ([#1062](https://github.com/gorakhargosh/watchdog/issues/1062) <https://github.com/gorakhargosh/watchdog/pull/1062>__)
Thanks to our beloved contributors: @apoirier, @BoboTiG

... (truncated)

Commits

76c091d Version 6.0.0
58386d8 Fixes, and clean-up (#1084)
db698a5 fix: reading inotify file descriptor after closing it. (#1081)
73d5612 [docs] Add typing info to quick start (#1082)
d774fec docs: Update README Badges (#1083)
6b74737 docs: funding
3d1b888 [inotify] Use of select.poll() instead of deprecated select.select() (#1078)
6a4f1cf Bump the version
ad6df50 Version 5.0.3
59650f8 fix: polish #1070
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

codecov · 2024-11-01T19:19:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.82%. Comparing base (676c9d5) to head (912db01).
Report is 26 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11114   +/-   ##
=========================================
  Coverage     20.82%   20.82%           
  Complexity     9115     9115           
=========================================
  Files           261      261           
  Lines         34966    34966           
  Branches        460      460           
=========================================
  Hits           7280     7280           
  Misses        27230    27230           
  Partials        456      456

Flag	Coverage Δ
autograder	`21.34% <ø> (ø)`
js	`2.13% <ø> (ø)`
migrator	`100.00% <ø> (ø)`
php	`19.51% <ø> (ø)`
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`88.88% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

williamjallen · 2024-11-21T13:52:21Z

This PR appears to break the code watcher script:

root@vagrant:/usr/local/submitty# submitty_code_watcher 
Traceback (most recent call last):
  File "/usr/local/submitty/GIT_CHECKOUT/Submitty/.setup/bin/code_watcher.py", line 88, in <module>
    main()
  File "/usr/local/submitty/GIT_CHECKOUT/Submitty/.setup/bin/code_watcher.py", line 70, in main
    observer.schedule(FileHandler(setup_path, 'site'), str(Path(git_path, 'site')), True)
TypeError: BaseObserver.schedule() takes 3 positional arguments but 4 were given

JManion32 · 2025-06-16T13:40:12Z

@dependabot rebase

JManion32 · 2025-06-24T16:23:19Z

@williamjallen The failure was being caused by a breaking change in version 5.0.0 that enforces keyword arguments. See feat!: more typing clean-up + enforce keyword-arguments #1057. Prior to this release, Watchdog could interpret the third value of observer.schedule as recursive=True. Now, it needs to be explicitly stated. After making this change, I was able to verify that the submitty_code_watcher script runs without the error. Is there any other things I need to check, or is this ready to merge?

JManion32 · 2025-06-24T19:00:46Z

@dependabot rebase

dependabot · 2025-06-24T19:00:49Z

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

JManion32 · 2025-06-24T19:01:04Z

@dependabot recreate

Bumps [watchdog](https://github.com/gorakhargosh/watchdog) from 4.0.1 to 6.0.0. - [Release notes](https://github.com/gorakhargosh/watchdog/releases) - [Changelog](https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst) - [Commits](gorakhargosh/watchdog@v4.0.1...v6.0.0) --- updated-dependencies: - dependency-name: watchdog dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Same changes as before the recreate. I verified that the daemon handler is still working correctly

williamjallen

@JManion32 Have you verified that the usage in sbin/submitty_daemon_jobs/submitty_jobs/handler.py works properly? That case is far more important than the code watcher because it affects production usage.

JManion32 · 2025-06-26T16:16:15Z

@JManion32 Have you verified that the usage in sbin/submitty_daemon_jobs/submitty_jobs/handler.py works properly? That case is far more important than the code watcher because it affects production usage.

I verified multiple times that Generate Grade Summaries, Rebuild Gradeable, and Bulk Upload still work as intended. I also looked over the code in sbin/submitty_daemon_jobs/submitty_jobs/handler.py and didn't see any bad usage. Additionally, commands from the Jobs Daemon & Debugging page on submitty.org were all working as expected with no errors, not sure if that helps. Is there anything else I should check?

dependabot bot added the dependencies label Nov 1, 2024

dependabot bot mentioned this pull request Nov 1, 2024

[Dependency] Bump watchdog from 4.0.1 to 5.0.3 in /.setup/pip #11047

Closed

github-actions bot added the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Nov 16, 2024

dependabot bot force-pushed the dependabot/pip/dot-setup/pip/watchdog-6.0.0 branch from 7c8aeb5 to a69c607 Compare November 17, 2024 12:57

williamjallen marked this pull request as draft November 21, 2024 13:51

williamjallen mentioned this pull request Nov 21, 2024

Add test for code watcher script #11158

Open

Seanlxx256 mentioned this pull request Dec 11, 2024

[Testing:CI] Add test for code watcher script #11158 #11237

Closed

2 tasks

williamjallen assigned JManion32 Jun 13, 2025

JManion32 removed Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete labels Jun 16, 2025

dependabot bot force-pushed the dependabot/pip/dot-setup/pip/watchdog-6.0.0 branch from a69c607 to 470fd23 Compare June 16, 2025 13:42

JManion32 marked this pull request as ready for review June 24, 2025 16:13

automateprojectmangement bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Jun 24, 2025

JManion32 requested a review from williamjallen June 24, 2025 16:23

automateprojectmangement bot moved this from Seeking Reviewer to In Review in Submitty Development Jun 24, 2025

dependabot bot force-pushed the dependabot/pip/dot-setup/pip/watchdog-6.0.0 branch from 4115702 to c3c4838 Compare June 24, 2025 19:01

Same changes

912db01

Same changes as before the recreate. I verified that the daemon handler is still working correctly

williamjallen reviewed Jun 25, 2025

View reviewed changes

bmcutler merged commit 37cf536 into main Jun 26, 2025
24 checks passed

bmcutler deleted the dependabot/pip/dot-setup/pip/watchdog-6.0.0 branch June 26, 2025 17:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dependency] Bump watchdog from 4.0.1 to 6.0.0 in /.setup/pip#11114

[Dependency] Bump watchdog from 4.0.1 to 6.0.0 in /.setup/pip#11114
bmcutler merged 2 commits intomainfrom
dependabot/pip/dot-setup/pip/watchdog-6.0.0

dependabot bot commented on behalf of github Nov 1, 2024 •

edited

Loading

Uh oh!

codecov bot commented Nov 1, 2024 •

edited

Loading

Uh oh!

williamjallen commented Nov 21, 2024

Uh oh!

JManion32 commented Jun 16, 2025

Uh oh!

JManion32 commented Jun 24, 2025

Uh oh!

JManion32 commented Jun 24, 2025

Uh oh!

dependabot bot commented on behalf of github Jun 24, 2025

Uh oh!

JManion32 commented Jun 24, 2025

Uh oh!

williamjallen left a comment

Uh oh!

JManion32 commented Jun 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dependabot bot commented on behalf of github Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

6.0.0

Breaking Changes

Other CHanges

5.0.3

5.0.2

5.0.1

5.0.0

Breaking Changes

Uh oh!

codecov bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

williamjallen commented Nov 21, 2024

Uh oh!

JManion32 commented Jun 16, 2025

Uh oh!

JManion32 commented Jun 24, 2025

Uh oh!

JManion32 commented Jun 24, 2025

Uh oh!

dependabot bot commented on behalf of github Jun 24, 2025

Uh oh!

JManion32 commented Jun 24, 2025

Uh oh!

williamjallen left a comment

Choose a reason for hiding this comment

Uh oh!

JManion32 commented Jun 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dependabot bot commented on behalf of github Nov 1, 2024 •

edited

Loading

codecov bot commented Nov 1, 2024 •

edited

Loading