error is displayed on firefox when changing thread lock date #11535
Description
Describe the bug
When changing the thread lock date on an existing forum thread an error pops up that says "Something went wrong when adding new thread. Please refresh the page.". The page automatically reloads after a few seconds and the update is saved. This error also occurs when editing a thread with a lock date, even if you do not change the lock date or any other fields. This error is likely to do with the websocket reconnect timing on firefox that makes this error appear to the user where it doesn't on Chrome or Edge.
Expected behavior
No error should pop-up since the thread is changed appropriately.
To Reproduce
Steps to reproduce the behavior:
- Open Submitty on firefox and log in as instructor
- Edit a thread that has a non-null Lock Thread Date
- Hit Update Post
- See error
Configuration
- OS: Windows
- Browser: Firefox
Screenshots
thread.lock.date.error.mp4
Additional context
This is not connected to setting the Thread Lock Date to null. I tested this on firefox, chrome, and edge. I found the error function in forum.js socketNewOrEditThreadHandler.