Implements #3697, ask before closing edit dialog on unsaved changes #3698
+113
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaults to false. When set to true, the edit dialog asks the user for confirmation first when they have unsaved changes and attempt to close the dialog. The user can either cancel the operation, keeping the dialog open, discard their changes, or save their changes. Implements Studio-42#3697
Contributor
Author
|
Hi, I see you merged the various pull requests, that's great, thank you ; ) Not sure if you saw it, but can I ask if you have an opinion regarding #3678 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option
commandsOptions.edit.confirmUnsavedBeforeClose.Defaults to
false. Whensetto true, the edit dialog asks the user for confirmation first when they have unsaved changes and attempt to close the dialog. The user can either cancel the operation, keeping the dialog open, discard their changes, or save their changes.Closes #3697