Allow image URL in theme manifest.json to be a relative link as well #3677
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative links are resolved against the manifest.json, the same way as is done for the CSS URL. This is needed when you are living places of the world where you need to host everything yourself, as linking to external servers is difficult due to privacy concerns. If your software can be hosted on different servers, everything needs to be relative to work properly.
Member
|
@blutorange Thanks!👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative links are resolved against the manifest.json, the same way as is done for the CSS URL.
This is needed when you are living places of the world where you need to host everything yourself, as linking to external servers is difficult due to privacy concerns. If your software can be hosted on different servers, everything needs to be relative to work properly.