Casey's mdspan review comments#28
Closed
CaseyCarter wants to merge 18 commits intoStephanTLavavej:mdspanfrom
Closed
Casey's mdspan review comments#28CaseyCarter wants to merge 18 commits intoStephanTLavavej:mdspanfrom
CaseyCarter wants to merge 18 commits intoStephanTLavavej:mdspanfrom
Conversation
…e the Standard mandates it
and fixes for the resulting failures.
... per the accessor policy requirements.
and avoid "detouring" through `operator[]` so we don't copy `OtherIndexType`s, which we aren't allowed to do. Fix test case that was expecting this bogosity.
This reverts commit 54b18c3. Thanks JMazurkiewicz for pointing out this is unnecessary and that the test coverage demonstrates it.
Owner
|
I pushed a couple of commits here, fixing a typo ("either be either equal" => "either be equal") and adding a missed change for a comment you made ( Then I tidied up the sequence of commits and pushed it into my mdspan branch instead of merging this PR, so you can see that the results are the same despite the history rewriting (I figured this was cleaner than a force-push). What I did was:
|
Owner
|
Really I should have squashed into "Defend against non- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's actually a small amount of changes for ~7k LoC. Please review by commits, which are nicely small and focused. This felt just extensive enough that I can imagine maybe putting off some of the changes, so I thought it would be better to make a delta PR rather than pushing into microsoft#3972.