Merged
Conversation
amanda11
reviewed
Dec 1, 2020
Contributor
There was a problem hiding this comment.
Changes look good. One minor comment.
Previously we mentioned that there was a need to add admin privileges to Stanley user. If we install the community RBAC does that get added by the bash installer or do you have to do that manually?
I think we should mention which happens.
arm4b
reviewed
Dec 2, 2020
arm4b
suggested changes
Dec 2, 2020
arm4b
reviewed
Dec 2, 2020
Contributor
|
I'm not sure what has happened, but this PR now only contains LDAP changes, rather than the RBAC ones @armab |
Member
|
Thanks @amanda11, fixed now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1038