upgrade hubot-botframework to commit #01d5be9#141
Closed
LizhangX wants to merge 3 commits intoStackStorm:masterfrom
Closed
upgrade hubot-botframework to commit #01d5be9#141LizhangX wants to merge 3 commits intoStackStorm:masterfrom
LizhangX wants to merge 3 commits intoStackStorm:masterfrom
Conversation
blag
suggested changes
Apr 12, 2020
Contributor
There was a problem hiding this comment.
I'm not a huge fan of pinning to a git commit, because that pretty much guarantees that we will need to bump the exact version again in the future, probably sometime soon.
As of August 27th, 2018, they do have a version 0.12.0-alpha1, it's just not pushed to NPM. Is there a way to specify a specific minimum version from a git repository?
Something like this:
"hubot-botframework": "git+https://github.com/microsoft/BotFramework-Hubot.git#^0.12.0",
If there isn't, then I'd prefer to pin to the most recent git commit, which is 01d5be9d98916243930bbe0b08be5212234fe40c as of now. Nevermind, I can't read. You have the correct git commit hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To better support MS Teams :)
Upgrade hubot-botframework to newest code right now (01/21/20).
Note: This is NOT my work, all this PR do is to point to the newer code to this dependency.
https://github.com/microsoft/BotFramework-Hubot
Issues fixed for me from v0.10.1 (latest from MS teams from 2017)