Copy dependency on st2-auth-backend-pam from st2-packages.git#6306
Merged
cognifloyd merged 6 commits intomasterfrom Feb 28, 2025
Merged
Copy dependency on st2-auth-backend-pam from st2-packages.git#6306cognifloyd merged 6 commits intomasterfrom
cognifloyd merged 6 commits intomasterfrom
Conversation
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == decorator 5.1.1 --> 5.2.1 psutil 6.1.1 --> 7.0.0 simplejson 3.19.3 --> 3.20.1 == Added dependencies == st2-auth-backend-pam 0.4.0
669bffd to
8e43d73
Compare
Contributor
|
Looks like the sample file needs to be regenerated for linting to pass. |
Member
Author
|
I'm going to have to add this to the legacy requirements as well. |
nzlosh
approved these changes
Feb 27, 2025
Contributor
|
Good find by the way 💯 |
guzzijones
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
st2-packages.git has been injecting another dependency since 2016 (StackStorm/st2-packages@d35c03e):
https://github.com/StackStorm/st2-packages/blob/7ed6bf12d101aa34456b711723be9f81d3be82d7/packages/st2/in-requirements.txt#L8
The legacy Makefile gets the dep indirectly via st2-packages.git, but that will be archived when we start using pants to build packages. So, this PR copies that requirement into
pants-requirements.txthere (and tost2auth/in-requirements.txt):st2/requirements-pants.txt
Line 81 in f350445
Then, since pants can't infer a dep on plugins like this, we explicitly add the dep here:
st2/BUILD
Lines 63 to 68 in f350445
Finally, I regenerated
lockfiles/st2.lockand copied the updated pins to the legacy requirements files. Here's the lockfile diff:NB: The
psutilmajor version bump merely drops support for python 2.7 and a deprecated method that we do not use.