Merged
Conversation
conf/st2.dev.conf already sets [coordination].url, so we do not need to use sed to enable it again. It looks like the st2.dev.conf change happened shortly after the sed logic was added to prepare-integration.sh.
nzlosh
approved these changes
Nov 13, 2024
amanda11
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR's commits were extracted from #6273 where I'm working on getting pants+pytest to run integration tests.
This PR just refactors some CI scripts to prepare for (a) running integration tests via pants, and (b) the PR where we enable configuring StackStorm via env vars (a new oslo_config feature). Since this is an internal-only change/refactor, I added the no changelogNo Changelog.rst needed for this PR
label.
It is probably easiest to review each commit+commit message of this PR as github's diff is confusing in at least one place.