Merged
Conversation
Eric-Arellano
approved these changes
Nov 24, 2022
81d6524 to
68ce404
Compare
68ce404 to
626e592
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to pants 2.14. We were on release candidates before.
pants 2.14 changed a default setting from
ignoretowarning, but most of the warnings are not actionable for us. Eventually, we should be able to address the warnings cleanly. For now, let's just ignore the warnings.Alternatively, we could add
# pants: no-infer-depcomments all over the place, which is not ideal.We can revisit this setting in pants 2.16. A new feature under development for 2.16 should make cleaning up these warnings much easier, and therefore worth the effort.