Conversation
|
The lint fails seem to do with astroid on python3.9 only, we are fixed to 2.5.6. Lots of fixes on later versions of astroid that mention python 3.9, but with newer versions of astroid our tests fail on both python3.8 and python 3.9. So not as simple as just upgrading astroid. Test failure: However if I use latest astroid/pylint combinations on python3.8 then the astroid parse on the pylint_plugins copy fails to find the property added after copy. (astroid 2.12.9). So with latest, test fails on both python3.8 and python3.9. Rolled back down to 2.6.6 astroid and still failed (python 3.8 as well). Can reproduce problem locally just with code: |
|
I hit the similar issues with py3.10 and astroid 2.15.5. |
python3.9 removed the Slice type from the AST, so the property_name_node is not as deep as expected.
|
Bingo: py3.9 changed the AST (python/cpython@13d52c2), dropping an intermediate Oddly, the pants-based run did not fail with 3.9 even though it should have. I suspect that pants might be using the wrong python for our tests. I will figure out + address that when I update pants in another PR. |
python3.9 removed the Slice type from the AST, so the property_name_node is not as deep as expected.
|
@cognifloyd Great find 💯 |
arm4b
left a comment
There was a problem hiding this comment.
Thanks a lot everyone!
let’s merge it
Investigate if any changes needed for unit or integration tests to work with python 3.9.